Parcourir la source

修复CoreReminderConfigurationServiceImpl.java中的逻辑错误,提高代码可读性。

jingyuanchao il y a 1 an
Parent
commit
bfd09626f6

+ 5 - 3
soc-modules/soc-modules-core/src/main/java/com/xunmei/core/reminder/service/impl/CoreReminderConfigurationServiceImpl.java

@@ -301,10 +301,12 @@ public class CoreReminderConfigurationServiceImpl extends ServiceImpl<CoreRemind
         minuteMap.put("label", "分钟");
 
         Duration duration = Duration.between(startTime, endTime);
-        long timeValue = duration.toDays() * 24L + duration.toHours();
-        timeValue /= count;
+        long timeValueInDays = duration.toDays(); // 直接计算相差的天数
 
-        if (timeValue >= 24) {
+        // 将相差天数除以count,得到每次执行任务所需的天数
+        long timeValue = timeValueInDays / count;
+
+        if (timeValue >= 1) {
             return Lists.newArrayList(dayMap, hourMap, minuteMap);
         } else if (timeValue >= 1) {
             return Lists.newArrayList(hourMap, minuteMap);